assert: reduce diff noise #23048
Closed
assert: reduce diff noise #23048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Assertion errors that produce a diff show a diff for identical entries in case one side of the comparison has more object properties than the other one. Those lines are now taken into account and will not show up as diverging lines anymore. Refs: nodejs#22763
nodejs-github-bot
added
the
assert
addaleax
approved these changes
Sep 24, 2018
It became hard to follow what was actually happening in the algorithm. This adds comments to improve the situation.
Leko
approved these changes
Sep 25, 2018
BridgeAR
added
the
author ready
|
Resumed build: https://ci.nodejs.org/job/node-test-commit/21760/ |
jasnell
approved these changes
Sep 25, 2018
|
Resumed build: https://ci.nodejs.org/job/node-test-commit/21768/ ✔️ (besides commit-linux) |
|
Rebuild commit-linux: https://ci.nodejs.org/job/node-test-commit-linux/21861/ |
|
Rebuild commit-linux again: https://ci.nodejs.org/job/node-test-commit-linux/21867/ ✔️ |
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
Sep 27, 2018
Assertion errors that produce a diff show a diff for identical entries in case one side of the comparison has more object properties than the other one. Those lines are now taken into account and will not show up as diverging lines anymore. Refs: nodejs#22763 PR-URL: nodejs#23048 Refs: nodejs#22763 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
Sep 27, 2018
It became hard to follow what was actually happening in the algorithm. This adds comments to improve the situation. PR-URL: nodejs#23048 Refs: nodejs#22763 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assertion errors that produce a diff show a diff for identical entries
in case one side of the comparison has more object properties than the
other one. Those lines are now taken into account and will not show up
as diverging lines anymore.
Refs: #22763
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes